You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more
This is a small, targeted build-fix PR with two files changed. Changes look correct overall.
list_runner_config_enabled_dcs.rs
The stream chain now wraps its result in Ok(...) to satisfy the Result<Vec<u16>> return type. This is the correct fix — the async stream chain resolves to Vec<_>, not Result<Vec<_>>, so the outer Ok() wrapper is required.
Minor style note: the trailing comma after .await, inside Ok(...) is unconventional but valid Rust.
runner_pool_backfill.rs
Pattern fix:(_, (_, _, leaf)) → (_, _, leaf) — the previous nested tuple destructuring was incorrect for unpacking (Id, String, usize). The flat pattern is correct.
Constant reference fix:keys::runner_config::PROTOCOL_VERSION → universaldb::utils::keys::PROTOCOL_VERSION — this aligns with the canonical constant location. Worth double-checking that both constants were previously identical in value. If keys::runner_config::PROTOCOL_VERSION was a re-export or separate definition with the same value, behavior is unchanged; if they had different values, this is a semantic change worth noting.
Summary
Both fixes are minimal and correct. No test coverage concerns for pure build fixes. The draft status is appropriate while the parent branch stabilizes.
Nit: The PR description is empty — a one-liner explaining which upstream change introduced these errors would be helpful for future git archaeology.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: